Re: Junior developers
From: Ryan Schmidt <subversion-2010a_at_ryandesign.com>
Date: Wed, 17 Feb 2010 11:34:56 -0600
On Feb 17, 2010, at 08:36, dcz wrote:
> Le 17/02/2010 15:24, Andy Levy a écrit :
I think it would be easy -- for the server or the JD manually -- to put together a patch -- it's simply:
svn di > patchfile
It could even be mailed to the SD straightaway:
svn di | mail sd_at_example.com
You could try to build this into the pre-commit script, but I'd think the JD would start getting annoyed that his patch review process keeps giving him negative feedback by telling him "Your commit was rejected with the following message" (or whatever the verbiage is that Subversion prints out). I'd also say it's confusing that the JD has to run "svn commit" when he's not really committing anything to the repository. Instead I'd suggest you write a new script, call it svnreview.sh or something, and have the JD run that instead. This script runs "svn di", maybe some other sanity checks first, then sends the email.
This is an archived mail posted to the Subversion Users mailing list.