[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN with code review workflow

From: Mark Phippard <markphip_at_gmail.com>
Date: Mon, 29 Jun 2009 13:31:21 -0400

On Mon, Jun 29, 2009 at 1:20 PM, Brian
FitzGerald<bmfitzgerald3_at_gmail.com> wrote:

>> It is nice and works well with SVN.  I think the best approach is the
>> way open-source projects like SVN handle it.  Developers use svn diff
>> to create a patch with their changes and mail it, along with the
>> commit message to a mailing list.  Developers can apply the patch and
>> reply to the email for the review.
>
> I'm not sure I follow here.  They mail and later apply the patch?  What do
> you mean by this?

You earlier suggested developers would physically get together and
review work. Coming from an open-source world, I just naturally
assume development is distributed and developers cannot physically get
together. This is pretty common practice in enterprise world these
days too where at least teams are distributed from each other.
Anyway, in the distributed world you cannot get together. So you
either post your patches to a tool like Review Board, or you email
them to a mailing list. The person that reviews the patch can do it
by just looking at the patch, or applying the patch to their own
working copy so that they can see the code in context and build and
run it etc.

Usually the review comments are either entered into the tool (such as
Review Board) or in emails.

A good example of this just happened today on SVN mailing list. See
this thread:

http://svn.haxx.se/dev/archive-2009-06/0560.shtml

An SVN committer asked for review before committing a patch. A couple
other committers replied with review comments. The original request
came from developer in India, so he probably went offline before
seeing the review and has not committed yet, but likely will tomorrow.
 He received review from two committers in Europe, one of whom, upon
being prompted to look at this code, has committed four other minor
unrelated improvements to the code today. See:

http://svn.collab.net/viewvc/svn/trunk/subversion/svnsync/main.c?view=log

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2366478
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-06-29 19:32:23 CEST

This is an archived mail posted to the Subversion Users mailing list.