[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN with code review workflow

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 29 Jun 2009 17:06:08 +0100

On Mon, Jun 29, 2009 at 11:38:19AM -0400, Brian FitzGerald wrote:
> Greetings all,
>
> I am a Web developer with a company who (rightfully so) places a large
> amount of importance on code review. For this reason, up to this
> point, they have not implemented a traditional version control system,
> such as Subversion.
>
> The concern of certain key people in the organization is that putting
> SVN in place would mean losing control of the code base in that
> developers could simply commit whatever, whenever they wanted, without
> going through the highly valued code review process.
 
The act of committing a change does not set things in stone.

> I understand their concern, and I have a few ideas about what could be
> some potential solutions to our problem, but I wanted to get thoughts
> from others about ways they have seen this tackled.

Subversion (like any other version control tool) is perfectly
suited to help achieve effective code review.

> What solutions have you all seen in action?

See http://producingoss.com/en/setting-tone.html#code-review
Note that this book describes development practices for open source
projects, and draws examples from Subversion's development itself.
But the same process could be used when developing proprietary software
if you're into that kind of thing.

Stefan
Received on 2009-06-29 18:07:13 CEST

This is an archived mail posted to the Subversion Users mailing list.