svnadmin dump/load patch, please test (was: Re: How long do your svn dumps take)

On Mon, Apr 20, 2009 at 02:39:15PM -0400, Bob Archer wrote:
> > > Once other datapoint for me. Our repository has a lot of binary
> files in
> > > it (VB6 dlls). I wonder if that could have something to do with it
> also.
> >
> > Could be. But we can only make blind guesses unless we gather some
> > profiler output. It would be greatly appreciated.
>
> As soon as someone can give me some direction on how to do this on
> Windows... I would be happy to run it again to get a profile.

Kevin sent me output of a profiled run of svnadmin load.

Greg Stein and I discovered that we don't do any buffering when
reading from stdin and writing to stdout.

Attached is a patch against the 1.6.x branch, and should enable
buffered reads/writes for APR versions >= 1.3.0 during svnadmin
dump and svnadmin load.

If you have APR >= 1.3.0 in your environment, please test this
patch and let us know if you see an increase in performance.

Once this has been confirmed to increase performance, we can
implement our own buffering so that people running APR < 1.3.0
can also benefit.

Thanks,
Stefan