[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: pre-revprop-change stdin wrong?

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 12 Feb 2009 08:31:30 +0200 (Jerusalem Standard Time)

Ryan Schmidt wrote on Wed, 11 Feb 2009 at 22:42 -0600:
> On Feb 11, 2009, at 18:15, kmradke_at_rockwellcollins.com wrote:
>
> > Using svn 1.5.1 FSFS and the http protocol, I created a pre-revprop-
> > change hook
> > script like this:
> >
....
> > subversion/libsvn_ra_neon/fetch.c:1175: (apr_err=175002)
> > svn: DAV request failed; it's possible that the repository's pre-
> > revprop-change hook either failed or is non-existent
> > subversion/libsvn_ra_neon/props.c:1151: (apr_err=175008)
> > svn: At least one property change failed; repository is unchanged
> > subversion/libsvn_ra_neon/util.c:206: (apr_err=175002)
> > svn: Error setting property 'log':
> > Revprop change blocked by pre-revprop-change hook (exit code 1)
> > with output:
> > This stdin is from pre-revprop-change:
> > -----
> > old log message
> > -----
> >

Just wondering, is it possible that the hook is called *twice* --- once
with the old log message, once with the new one?

> >
> > I see a few things wrong here:
> >
> > 1) That is an ugly error message
> > 2) The pre-revprop-change script gets the OLD log message passed to
> > stdin when it should
> > get the NEW log message according to the tmpl file.
>
> On Subversion 1.5.5 with Mac OS X 10.4.11 Intel, I see:
>
> $ svn propedit --revprop -r 1 svn:log
> svn: Revprop change blocked by pre-revprop-change hook (exit code 1)
> with output:
> This stdin is from pre-revprop-change:
> -----
> new log message
>
> -----
>
> So, my error is shorter (do you have some debug options turned on
> causing more verbose error messages?)

In maintainer mode, you get file.c:line numbers in the output. Anyway,
in this case you also see a slightly different error chain, indicating
that either you use different RA layers or different svn releases (there
was recently a fix to remove some DAV details from error messages).

> and my stdin does contain the new log message, not the old one.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=1143289

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-02-12 23:31:53 CET

This is an archived mail posted to the Subversion Users mailing list.