[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Code Reviewing

From: David Weintraub <qazwart_at_gmail.com>
Date: Fri, 30 Jan 2009 09:12:45 -0500

We have added Findbugs <http://findbugs.sourceforge.net/> which
integrates into Hudson <https://hudson.dev.java.net/>.

The problem is our legacy code. When we first started using Findbugs,
it started off with a lot of energy, but recently Findbugs has been
missing work. When Findbugs does come in, he reeks of alcohol and is
quite beligerent. The other day, I walked by the build machine and
heard Findbugs crying, "I just can't hack it. I just can't hack it."

Findbugs works great with the newer stuff we're doing in Maven, but
our Legacy code has years of awful design and layers of strange coding
practices, and this is where we really need code reviews. It is also
where we have the biggest teams working on it and the most bad habits.

On Thu, Jan 29, 2009 at 4:28 PM, Bob Archer <Bob.Archer_at_amsi.com> wrote:
>> Thanks. It looks really nice. I think the main problem we have here is
>> that we are relying on code reviews as a way of taking care of poor
>> programming practices.
> You could add static code analysis tool like FxCop to your build system.
> This will be an automated "code review" that can catch a lot of bad
> practices bad naming conventions etc. Your devs should run it before
> check-in because they know any FxCop violations will break the build.
> BOb

David Weintraub
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-01-30 15:13:45 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.