Re: Code Reviewing

On Wed, Jan 28, 2009 at 3:16 PM, Blair Zajac <blair_at_orcaware.com> wrote:

> We're using Review Board to review commits in svn. You can have it as a
> pre-commit process and commit after approval or you could have a post-commit script post commits into review board for further discussion.
>
> It's an open-source project written in Python:
>
> http://www.review-board.org/
>

Thanks. It looks really nice. I think the main problem we have here is
that we are relying on code reviews as a way of taking care of poor
programming practices.

To me, code reviews were mainly concerned with looking for gotchas --
not testing a particular end condition, having a hole in a loop (like
Microsoft's infamous Zune year end bug). If a code review finds that
major modification of the code is needed, then you need to look at
whether the developer is adequately trained.

--
David Weintraub
qazwart_at_gmail.com
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=1069460
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].