[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Code Reviewing

From: David Weintraub <qazwart_at_gmail.com>
Date: Thu, 29 Jan 2009 12:40:06 -0500

On Wed, Jan 28, 2009 at 3:16 PM, Blair Zajac <blair_at_orcaware.com> wrote:

> We're using Review Board to review commits in svn. You can have it as a
> pre-commit process and commit after approval or you could have a post-commit script post commits into review board for further discussion.
> It's an open-source project written in Python:
> http://www.review-board.org/

Thanks. It looks really nice. I think the main problem we have here is
that we are relying on code reviews as a way of taking care of poor
programming practices.

To me, code reviews were mainly concerned with looking for gotchas --
not testing a particular end condition, having a hole in a loop (like
Microsoft's infamous Zune year end bug). If a code review finds that
major modification of the code is needed, then you need to look at
whether the developer is adequately trained.

David Weintraub
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subversion.tigris.org].
Received on 2009-01-29 18:41:02 CET

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.