[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Candidate bug: svnadmin should refuse to create nested repositories

From: Steven J. Murdoch <svn+Steven.Murdoch_at_cl.cam.ac.uk>
Date: Fri, 22 Aug 2008 19:20:17 +0100

On Fri, Aug 22, 2008 at 10:41:21AM -0700, Hyrum K. Wright wrote:
> r32636, for those that are interested.

Great, that was fast :-)

I submitted a bug report (Issue 3269) anyway, since I had one ready
and it is sometimes helpful to have bug reports for reference, even if
they are immediately closed.

To answer your original question, I think only checking the parent of
the repository to create would be a substantial improvement, and would
have caught the incident I was cleaning up.

However, my preference (and what you appear to have implemented) is to
go all the way up to the root. This would catch the more obscure case
of "mkdir /path/to/repos/foo; svnadmin create /path/to/repos/foo/bar".

A slightly more plausible case that going up to the root would catch
is "svnadmin create /path/to/repos/db/bar" (since db already exists).

Thanks again for your very fast response.


w: http://www.cl.cam.ac.uk/users/sjm217/
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-08-22 20:20:46 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.