[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Incorrect lock becuase post-lock fails

From: Giulio Troccoli <Giulio.Troccoli_at_uk.linedata.com>
Date: Mon, 30 Jun 2008 11:03:12 +0100

I know it's not good etiquette to repost the same issue again, and that
you all look at this mailing list in our own spare time, but a week as
passed and nobody has said anything about it.

Has anybody been able to reproduce the issue? Is it a bug and shall I
file a bug report?

Giulio

> -----Original Message-----
> From: Giulio Troccoli [mailto:Giulio.Troccoli_at_uk.linedata.com]
> Sent: 23 June 2008 15:01
> To: users_at_subversion.tigris.org
> Subject: Incorrect lock becuase post-lock fails
>
> I have found something that, in my view, is a bug. It's easily
> reproducible with the script attached (it's a Korn Shell script but
it'd
> be easy to change it for Windows).
>
> If the post-lock hooks fails, the user get the message "Lock
succeeded,
> but post-lock hook failed". It seems correct, especially because,
AFAIK,
> the exit code of the post- hook doesn't matter.
>
> The file is indeed locked, but with a status of O instead of K. From
the
> Subversion book, O means that the files is locked by someone else
> (wrong) or somewhere else (wrong). Although the file seems to be
locked,
> if it has the svn:needs-lock property set it's still read-only (but
> maybe this is related to the fact that Subversion thinks that the file
> is not locked in that WC).
>
> I discovered the problem because my post-lock script did not have an
> "exit 0" at the end and the return code was not zero (there was an
error
> with the set command). As you can see, my script simply creates a
> post-hook with "exit 1" to make it failing.
>
> Anyhow, I believe this is not the correct behaviour. As clearly state
in
> the message that Subversion returns, the lock has succeeded (as it
> should since the post-lock return code shouldn't matter) but not in
the
> right way: you cannot commit, nor you can unlock the file. The only
way
> to remove the lock is to use svnadmin rmlocks.
>
> I'm using Subversion 1.4.4
>
> Am I missing something or is it really a bug?
>
> Thanks
> Giulio
>
> P.S. In the wrong-lock script you need to change the path of the
> repository when checking out the WC
>
>
> Linedata Services (UK) Ltd
> Registered Office: Bishopsgate Court, 4-12 Norton Folgate, London, E1
6DB
> Registered in England and Wales No 3027851 VAT Reg No 778499447

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-06-30 12:03:47 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.