[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit doesn't show unknown files.

From: Mark E. Hamilton <mhamilt_at_sandia.gov>
Date: Thu, 22 May 2008 16:42:02 -0600

Karl Fogel wrote:
> "Mark E. Hamilton" <mhamilt_at_sandia.gov> writes:
>> In discussing our upcoming switch to subversion with some of our
>> developers, I was asked why 'svn commit' doesn't show unknown files
>> (those that appear with a '?' in 'svn status') in the svn-commit.tmp
>> file brought up in the editor. I thought I would raise the question
>> here.
>> The rationale for having it do this is that it's the last point at
>> which the developer can see what is being committed, and decide
>> whether of not it is correct. (In fact, that would seem to be the
>> reason for displaying the files that are being committed.) Since it's
>> not uncommon for developers to forget to 'svn add' something, it would
>> seem useful to display both the files that would be committed and the
>> files that would not be committed, since the latter might include some
>> forgotten files.
> That's an interesting question...
> I think it would make sense to show them, after all the modified files.
> How hard this would be to do, I have no idea. Have you had a look at
> writing the patch? http://subversion.tigris.org/hacking.html#patches

Well, I wrote the original e-mail right after the discussion in which it
was brought up. I hadn't even thought of doing it myself. I will have a
look at it, but not being familiar with the svn code I don't know how
successful I'll be. Still, I'll give it a shot. At first look it seems
that the relevant code might be svn/util.c:svn_cl__get_log_message.

Mark E. Hamilton
Orion International Technologies, Inc.
Sandia National Laboratory, NM.
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-05-23 01:11:27 CEST

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.