[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

WIN32_RETRY_LOOP on Cygwin (was: Subversion 1.5.0 Release Candidate 4 Released)

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Mon, 28 Apr 2008 14:38:47 -0400

Spiro Trikaliotis <news-200803_at_trikaliotis.net> writes:
> I have not tested this version yet, but from the source, I see that one
> behaviour is the same as with 1.4:
>
> In subversion-1.5.0-rc4/subversion/libsvn_subr/io.c, the
> WIN32_RETRY_LOOP is defined as loop only if WIN32 is defined.
> Unfortunately, for Cygwin, this means that this work-aroundy is not
> performed, as WIN32 is not defined there.
>
> Is it possible to change this
> #ifdef WIN32
> to
> #if defined(WIN32) || defined(__CYGWIN__)
>
> so Cygwin can profit from this work-around, too?

I've CC'd dev@ on this response.

I don't have enough background knowledge to anticipate all the "gotchas"
here, but this seems reasonable to me. Cygwin doesn't mask over the
behavior of other processes in Windows, or low-level filesystem
behaviors, right? So it makes sense that WIN32_RETRY_LOOP() would be
necessary in Cygwin too.

However, I'd like to hear comments from other developers with more
Windows and Cygwin experience...

> (Please, compare the thread I started on the Cygwin mailing list here:
> http://www.cygwin.com/ml/cygwin/2008-04/msg00550.html)
>
> Additionally, the current SVN client (1.4.6) always uses LF line endings
> as "natural" line endings in cygwin, regardless if cygwin has been
> installed with LF line-endings, or with CR/LF line endings.

Hmmm, how does Subversion determine the "native" end-of-line convention?
I'd think we just ask APR somehow; if so, the question is, why isn't APR
getting the right answer on Cygwin?

> I wanted to test this with the current 1.5.0RC4, but I was not able to
> compile it myself. (Yes, I would prefer a pre-built version of this.)
> Will there be a change with 1.5.0RC4, or does it still behave the same
> here?

I didn't understand your final question (reword it?), but re prebuilts:
I don't know of any, and search://subversion "1.5.0-rc4" prebuilt/ turns
up only your mail :-).

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: users-help_at_subversion.tigris.org
Received on 2008-04-28 20:39:36 CEST

This is an archived mail posted to the Subversion Users mailing list.