[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Can Subversion aid code reviews?

From: John Rouillard <rouilj_at_renesys.com>
Date: 2007-11-02 18:38:18 CET

On Fri, Nov 02, 2007 at 09:38:21AM -0700, Rene Medellin wrote:
> --- "Bicking, David (HHoldings, IT)"
> <David.Bicking@thehartford.com> wrote:
> > We're looking at code review processes here, and I would like to
> > know what people here in this forum do for code reviews. Can
> > Subversion itself supply help in a code review process? Some
> > suggest that "promotion groups" are the way to go, which
> > Subversion does not support. A basic process we have in mind goes
> > something like this:
> >
> > 1. developer is assigned a task, builds the code,
> > unit tests it.
> > 2. The team lead reviews the code, and might assign
> > work to make changes.
> > 3. The developer makes the changes and notifies the
> > team lead
> > 4. The final review is done and the task is closed.
> >
> > Some core issues here around source control
> > include, how to identify what falls in the task
> > (which will span several revisions), how to report
> > on code that is unreviewed, and how to flag said
> > code as reviewed.
> >
> > This sounds to me like "branch by task", but we're
> > not necessarily talking about large tasks, and we
> > don't want to branch frequently (let alone have
> > each team member branch for each of their tasks).
> Use Crucible.
> http://www.atlassian.com/software/crucible

Well, you could also use CodeStriker for a free version
of a structured online code review process, (I haven't
used either but they seems to do similar things).

But in both cases AFAICT you need to do a feature/bug
branch and code review the code on that branch. Once
you have reviewed code on that branch at a particular
revisions (so you review branches/ticket24@2002), the
CM manager or somebody else merges the change into the

There is no provision for shelving changes until they
are reviewed so you can keep working on the trunk, but
not have those changes visible until they are approved.

				-- rouilj
John Rouillard
System Administrator
Renesys Corporation
603-643-9300 x 111
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Fri Nov 2 18:38:43 2007

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.