[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Issue specifying hostname in commit-email.pl; regex bug?

From: Andrew R Feller <afelle1_at_lsu.edu>
Date: 2007-05-09 16:45:45 CEST

While trying to use the commit-email.pl script, I was having issues
specifying the hostname to be appended to the author information
(lsu.edu). Whenever the script ran, it would complain that the hostname
argument (-h <hostname>) wasn't missing. After looking into the source
code, I noticed the regular expressions used; they want the hostname to
be a single character?!

The following snippet is from the CollabNet's 1.4.3 tag of
commit-email.pl. The latest version from trunk has the same code as
well.
(http://svn.collab.net/repos/svn/tags/1.4.3/tools/hook-scripts/mailer/ma
iler.py)

========================================================================
if ($from_address =~ /\w/)
  {
    $mail_from = $from_address;
  }
elsif ($hostname =~ /\w/)
  {
    $mail_from = "$mail_from\@$hostname";
  }
elsif (defined $smtp_server)
  {
    die "$0: use of either `-h' or `--from' is mandatory when ",
        "sending email using direct SMTP.\n";
  }
========================================================================

Does anyone know if I am missing something or is this a legitimate bug?

Thanks,
A-

Andrew R Feller, Analyst
Subversion Administrator
University Information Systems
Louisiana State University
afelle1@lsu.edu
(office) 225.578.3737

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed May 9 16:46:28 2007

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.