[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for issue 2349

From: Alan Barrett <apb_at_cequrux.com>
Date: 2006-10-09 17:33:00 CEST

On Sun, 08 Oct 2006, Karl Fogel wrote:
> Marco Yu <marco_yu@mentor.com> writes:
> > We use an url in the form of svn+ssh://foo@svnsvr/. svn ls prints
> >
> > svn: Syntax error parsing revision 'jediweb.sje.mentorg.com'
> >
> > Basically the parser confuses the @ in the URL for a pegged revision

I think it's a bug for "@" characters anywhere other than after the
last "/" to be considered as introducing peg revisions. Even if you
disagree with that proposition, I hope you'll agree that it's a bug for
"@" before the third slash in a "scheme://authority/path" URL to be
treated as a pegrev introducer.

> Subversion has a run-time fix, just append "@" to the URL. Would that
> work for you?

I didn't know about that, but I wouldn't call it a "fix"; it's a
workaround.

> I tentatively think I'm not in favor of this change, because it
> complicates our peg-revision syntax semantics, and may lock us out of
> future extensions of revision syntax (e.g., there are already some
> non-numeric revision strings, such as "BASE", "HEAD", etc).

Do you want to reserve the possibility that "/" might one day be a
valid character *inside* a peg revision specifier? I would find that
confusing; I think that treating "/" as a path separator should have
higher priority than treating "@" as a peg revision introducer.

--apb (Alan Barrett)

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Oct 9 17:34:07 2006

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.