[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch for issue 2349

From: Marco Yu <marco_yu_at_mentor.com>
Date: 2006-10-07 02:21:00 CEST

Hi,

    We use an url in the form of svn+ssh://foo@svnsvr/. svn ls prints

svn: Syntax error parsing revision 'jediweb.sje.mentorg.com'

Basically the parser confuses the @ in the URL for a pegged revision
syntax. Here's a patch I use to fix this problem. Essentially I just
disable the error message when it thinks it should expect a revision
number and fallback to have svn try the other syntax.

Is this an appropriate fix?

Thanks,

Marco

***
/home/jedi/replica/src/subversion/subversion-1.3.1/subversion/libsvn_subr/opt.c 2006-09-28 14:52:10.000000000 -0700
--- opt.c 2006-01-18 11:47:55.000000000 -0800
***************
*** 526,540 ****
              }
   
            if (ret || end_revision.kind !=
svn_opt_revision_unspecified)
! {
! /* return svn_error_createf (SVN_ERR_CL_ARG_PARSING_ERROR,
NULL,
                                        _("Syntax error parsing revision
'%s'"), path + i + 1);
- */
- *truepath = svn_path_canonicalize (path, pool);
- rev->kind = svn_opt_revision_unspecified;
- return SVN_NO_ERROR;
- }
   
            *truepath = svn_path_canonicalize (apr_pstrndup (pool, path,
i),
                                               pool);
--- 526,534 ----
              }
   
            if (ret || end_revision.kind !=
svn_opt_revision_unspecified)
! return svn_error_createf (SVN_ERR_CL_ARG_PARSING_ERROR,
NULL,
                                        _("Syntax error parsing revision
'%s'"), path + i + 1);
   
            *truepath = svn_path_canonicalize (apr_pstrndup (pool, path,
i),
                                               pool);

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sat Oct 7 02:21:31 2006

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.