[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Automatically tidying up code upon checkin

From: Kalin KOZHUHAROV <kalin_at_thinrope.net>
Date: 2005-09-15 17:57:40 CEST

Ryan Schmidt wrote:
> On Sep 15, 2005, at 17:07, Greg Thomas wrote:
>
>> On Thu, 15 Sep 2005 16:35:28 +0200, Felix Gilcher wrote:
>>
>>> On Sep 15, 2005, at 16:09, Kevin Old wrote:
>>>
>>>> Occasionally, I use PerlTidy (perltidy.sourceforg.net) to clean up my
>>>> code, and wondered if first, it was a good idea to investigate havning
>>>> Subversion do this prior to checkin. Second, (if this is a good idea)
>>>> which level of hook script should I implement this?
>>>
>>>
>>> There are several threads here on this list explaining why you
>>> should never manipulate code in a pre-commit-hook script.
>>
>>
>> However, you could do it in a post-commit hook. This would have to
>> checkout a wc on the server, run the tidy script over the code, and
>> then commit the changes, before cleaning up after itself.
>
>
> And then Kevin makes additional changes to his code and tries to commit
> that, and it doesn't work because his working copy is out-of- date. Then
> he does an update and gets conflicts because the pretty- printed old
> code is likely not mergeable with his non-pretty-printed new code. It's
> just one problem after another.
>
> Best answer is to Just Say No to automatic repository-side pretty-
> printing. Do it on the client side if you must do it at all.

To pour some more oil in the fire :-) Does this sound as clinet-side hooks ?

Oh, when will I run down to #313 in my TODO:
313: Patch subverson CLI to support client-side hooks

Kalin.

-- 
|[ ~~~~~~~~~~~~~~~~~~~~~~ ]|
+-> http://ThinRope.net/ <-+
|[ ______________________ ]|
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Sep 15 18:00:49 2005

This is an archived mail posted to the Subversion Users mailing list.