To each his own. I am certainly not saying we must do away with the
current option. But most people just dont want to run comprehensive
checks against all data in a PRE-commit. (I'm in the proccess of adding
comprehensive checks as a /post/ commit, but then I also need to send
the source to numerous systems to do that check. More to the point-
these checks take a long time, as do many checks which would act on the
data. I guess it's more of an opinion/style thing, but I dont like
making people wait for a commit to go through- and that's the whole
point. They should know A.S.A.P. the status of their commit.
I have, however, been thinking along the lines of creating some way to
mark a commit as "No Good" (through a wrapper I've been calling
svnoops). Basically, you have the ability to say "This commit is not
good. Do not check out this commit.". Then -rHEAD or a simple update
would act only on "Good" copies.
People do shitty things. That's what version control is for ;)
Ryan Schmidt wrote:
> On 20.08.2005, at 05:52, Vincent Starre wrote:
>
>> the majority of pre-commit hook scripts I have seen have to do with
>> metadata: filename, mime-type, eol settings, file size. "Is it okay
>> for this file to be checked in?", as far as I have seen, rarely
>> checks the file content itself (and if you're not checking if it's
>> okay for the file to be checked in, you tend to use a /post/commit
>> hook). Due to this, I wouldnt think the number of cases where this
>> optimization /wouldnt/ pay off would be all too high.
>
>
> When I get a minute, I hope to have our pre-commit hook check the
> syntax of all committed PHP files. Some of our programmers love doing
> global search-replace operations across thousands of PHP files, of
> course do not thoroughly test all the changes, and end up committing
> garbage that does not compute
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: users-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sun Aug 21 00:14:01 2005