[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Suspected Memory Leak for merge

From: John Szakmeister <john_at_szakmeister.net>
Date: 2005-07-13 22:35:24 CEST

On Wednesday 13 July 2005 15:40, Brian Buesker wrote:
> John Szakmeister wrote:
> >Can you try using the 1.2.1 release and just merging in r15233? I
> > think the segfault is an unrelated issue relating the the new
> > property merging algorithm.
>
> Yes, you are right that the seg fault was unrelated. However, taking
> 1.2.1 and merging in r15233 did not fix the problem. I have attached
> the top output for this run. The last one I sent may not have been a
> complete log (I may have ended the script early. I don't remember now),
> so I wouldn't get concerned right away that this one shows much larger
> values.
>
> Please let me know if you want me to try anything else.

Actually, I do have one more thing for you to try. You said you're using
a perl script that basically does the following:
> my $client = new SVN::Client( auth =>
[SVN::Client::get_simple_provider(),
>                       SVN::Client::get_username_provider(),
>                     SVN::Client::get_ssl_server_trust_file_provider()]);
>
> $client->checkout (...);
>
> for my $i ( 1 .. $n ) {
>    $client->merge (...);
> }
>

Can you change that last part to be:
  my $subpool = SVN::Pool->new_default;
  for my $i ( 1 .. $n ) {
     $subpool->clear;
     $client->merge (..., $subpool);
  }

Some of these client functions aren't as well behaved as they probably
should be. They make allocations of out the pool passed to them, but we
don't clear the pool. We should probably be using a subpool for
temporary allocations in the svn_client functions, and only using pool
parameter for data that needs to last longer.

BTW, is there some way you can narrow down what caused the segfault with
the property merge? I'd like to make that problem go away too.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed Jul 13 22:36:53 2005

This is an archived mail posted to the Subversion Users mailing list.