[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Email stolen lock to original lock holder

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2005-07-07 16:39:35 CEST

On Jul 7, 2005, at 2:08 AM, Bruno Gustavs wrote:

> This post referes to Subversion 1.2.0.
>
> I tried to notify stolen locks by email to the original lock holder.
> When I notify from the pre-lock script I get far too much
> notifications, because the pre-lock script runs even if the
> svn lock command is run without --force and will fail therefore.

Aha! This is definitely a bug.

The libsvn_repos library invokes 'pre-lock' before asking the
filesystem (libsvn_fs) to create the lock. libsvn_repos knows
whether or not the user passed --force, and it can find out if a lock
already exists... so instead of running pre-lock and letting
libsvn_fs reject the request, *libsvn_repos* should be rejecting the
request upfront, and not run 'pre-lock' at all.

Will fix this bug today, thanks for reporting.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Jul 7 16:46:17 2005

This is an archived mail posted to the Subversion Users mailing list.