[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn:keywords parsing bug

From: Miha Vitorovic <mvitorovic_at_nil.si>
Date: 2005-06-28 10:11:39 CEST

"Max Bowsher" <maxb@ukf.net> wrote on 28.06.2005 05:18:04:

> >> On Jun 27, 2005, at 12:54 PM, Miha Vitorovic wrote:
> >>
> >>> For example:
> >>>
> >>> svn:keywords="Date Revision Id" -- Only $revision$ gets
> >>> replaced like
> >>> this.
> >>>
> >>> svn:keywords=" Date Revision Id " -- All three keywords work.
> >>>
> >>> I noticed this on Windows XP, command line client.
> >>

> > Kris Deugau <kdeugau@vianet.ca> wrote on 27.06.2005 20:35:30:
> >>
> >> I've seen this; my guess is that the quotes end up parsed as part of
> >> the keyword. :/ Removing the quotes works fine.
> >

>
> Read that 'confirmation' again. Kris' guess is correct.
> Quotes are not part of the format of the Subversion configuration files,
and
> it is an error to use them. Not a bug.
>

While I agree that it is an input error, I am also inclined to argue that
multi-value command arguments are often delimited by quotes and that
obviously many/some users include them without thinking. So the client
could either handle them correctly if they are present, or the help screen
could make it absolutely clear, that the PROPVAL treats quotes as a value,
not as a delimiter - unlike the --message parameter, for example.

That's just my $0.02, but I'll be happy to omit the quotes from now on.

Cheers,

---
  Miha Vitorovic
  Inženir v tehničnem področju
  Customer Support Engineer
   NIL Data Communications,  Tivolska cesta 48,  1000 Ljubljana,  Slovenia
   Phone +386 1 4746 500      Fax +386 1 4746 501     http://www.NIL.si
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Tue Jun 28 10:14:38 2005

This is an archived mail posted to the Subversion Users mailing list.