[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Post Commit Code Formatting

From: Servico Tpd Rodrigo Alfonso Menezes Madera <tpd.madera_at_telefonica.com.br>
Date: 2005-06-22 21:20:43 CEST

[I pressed some key combos in this strange Lotus Notes editor and it sent a
e-mail chunk... sorry]

It seems that this thread has everything to do with my code format thread.

Karl seemed irritated when we assume that it would be simple. Well, maybe
the "working" way would be to wrap the commands in scripts for now.

Abot formatters breaking code, they shouldn´t in theory. If that happens,
the formatter stinks anyway.

My 0,1e-12 cents worth,

Rodrigo

                                                                                                                                       
                      kfogel@collab.ne
                      t Para: "Durfee, Bernard" <Bernard.Durfee@suny.edu>
                      Enviado Por: cc: users@subversion.tigris.org
                      kfogel@newton.ch Assunto: Re: Post Commit Code Formatting
                      .collab.net
                                                                                                                                       
                                                                                                                                       
                      22/06/2005 16:05
                      Responder a
                      kfogel
                                                                                                                                       
                                                                                                                                       

"Durfee, Bernard" <Bernard.Durfee@suny.edu> writes:
> I've seen this topic come and go over the years in CVS and now in
> Subversion. It amazes me the amount of resistance put forth by the
> maintainers of both of these projects. It's just a feature. A useful
> feature that can be used or ignored. Providing a simple hook somewhere
> in the commit path to run a script to format the incoming file before
> the commit and to transmit the changes back to the client.

The resistance is due to the difficulty of implementing it. I don't
know why you think it's "simple". I notice you haven't submitted a
patch for it, or even a design proposal that addresses all the
technical issues.

You can continue to be "amazed" by the resistance, or you can try to
solve the problem yourself, and see how simple it is or isn't.

> Whether or not automatic formatting of committed files is appropriate is
> a purely philosophical debate. In my mind it is simply an extension of
> the already convenient RCS keyword expansion provided by both CVS and
> Subversion. Imagine, if you will, a world in which RCS keyword expansion
> didn't exist. Would you ask developers to make sure to update the
> revision number and commit time in each file before they committed it?
> Why force them to remember to run the code through a formatter before
> they commit it?
>
> Please CVS and Subversion, give the world a way to easily and
> appropriately integrate code formatters.

Our opposition to the feature is not on philosophical grounds, it's on
the technical grounds that not worth the trouble to implement. If you
say that's wrong, then you're saying it *is* worth the trouble to
implement. So, implement it!

This is how things get done around here.

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed Jun 22 21:18:52 2005

This is an archived mail posted to the Subversion Users mailing list.