[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Log messages have an extra blank line when autoedited

From: DervishD <privado_at_dervishd.net>
Date: 2005-04-18 13:10:30 CEST

    Hi all :)

    First of all, I'm using Subversion 1.1.4.

    This is really not a bug, just a cosmethic issue, but affects to
the XML output too, so I think it may be convenient to report.

    The fact is that if you add a comment when commiting using '-m'
or '-F', the log comment has exactly the contents you specify, it
doesn't have an extra blank line at the end if you don't put one
there. Using 'svnadmin setlog' acts exactly the same. The problem
arises when you do 'svn commit' and subversion starts your editor to
add the log comment, then a blank line is always added at the end of
the comment, and this is inconsistent which the other methods.

    The cause is at clients/cmdline/util.c, in function
truncate_buffer_at_prefix. After truncation it should remove the last
newline character, if any. Since this may have lateral effects I
don't provide a patch, I don't want to screw things O:)

    Thanks a lot in advance :)

    Raúl Núñez de Arenas Coronado

-- 
Linux Registered User 88736
http://www.dervishd.net & http://www.pleyades.net/
It's my PC and I'll cry if I want to...
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Apr 18 13:44:31 2005

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.