[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Commit hooks malfunctioning... Bug?!

From: Ryan Schmidt <subversion-2004_at_ryandesign.com>
Date: 2005-01-22 17:21:30 CET

On 21.01.2005, at 02:57, Dassi, Nasser wrote:

> 1. svn status > random.txt (Works)
> 2. cscript blah.vbs (Runs -> creates a file, random1.txt)
> 3. svn add --targets random1.txt (Fails)
> 4. del random.txt (Works)
> 5. del random1.txt (Works)

On 21.01.2005, at 21:42, Dassi, Nasser wrote:

> The "bug?" may just be my misunderstanding; here it is, in the form of
> a
> question for the Subversion Dev Team to give a crack at it:
>
> Q: Is it possible for a HOOK (start/pre/post-commit) to access WC
> Add/Delete commands (via "svn add" and "svn delete")?
>
> Bkgnd: From this thread conversation with Simon Martel, it appears that
> a HOOK *cannot* modify the working copy from which it was instantiated.
> Running hook scripts *outside* of a WC "svn commit" command is not a
> problem; but based on the WC's "commit" it seems to not execute
> ADD/DELETE commands. "svn up" works fine from within a hook script,
> though.

Yes, that's what I understand from reading The Book:

http://svnbook.red-bean.com/en/1.1/ch05s02.html

> Warning
>
> Do not attempt to modify the transaction using hook scripts. A common
> example of this would be to automatically set properties such as
> svn:eol-style or svn:mime-type during the commit. While this might
> seem like a good idea, it causes problems. The main problem is that
> the client does not know about the change made by the hook script,
> and there is no way to inform the client that it is out-of-date. This
> inconsistency can lead to surprising and unexpected behavior.
>
> Instead of attempting to modify the transaction, it is much better to
> check the transaction in the pre-commit hook and reject the commit
> if it does not meet the desired requirements.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sat Jan 22 17:23:50 2005

This is an archived mail posted to the Subversion Users mailing list.