[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Resend: Output from post-commit hook

From: Erik Williamson <erik_at_cpsc.ucalgary.ca>
Date: 2004-11-15 07:38:42 CET

Aha!

Yes - that was my idea originally - run the 'make verify' in the
pre-commit - and it does return an error to the client there, when
appropriate. But then I got all confused (New to Subversion) - if this
is pre-commit, the new version isn't checked in yet - so where is the
file that I'm trying to play with? In initial testing, it was using the
last good version that was checked in. Is there a repository admin
command that shows me the file that they're trying to check in? I took
a peek but nothing jumped at me. I'll do some more digging.

Thanks for bringing this up, I appreciate it!

Best,
Erik.

Ben Collins-Sussman wrote:
>
> On Nov 12, 2004, at 10:28 PM, Erik Williamson wrote:
>
>>
>> A 'make verify' runs first which determines if it's valid XML; if it
>> isn't they need to know that they've messed up and that the
>> appropriate servers will not be updated.
>>
>
> If 'make verify' is so quick, then here's a better idea: run that
> command in a pre-commit hook. If the verification fails, the entire
> commit is rejected. That's real enforcement. (And also: the
> pre-commit hook actually returns 'stderr' output to the user.)

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Mon Nov 15 07:39:09 2004

This is an archived mail posted to the Subversion Users mailing list.