Thursday, October 7, 2004, 12:14:30 AM, Khairul Azhar wrote:
> On Wed, 6 Oct 2004 23:28:03 -0400, John Szakmeister
> <john@szakmeister.net> wrote:
>
>> However, the more I think about this, the more I think
>> GetModuleFileNameW() isn't necessarily to blame. If Win 98 didn't have
>> this function at all, the loader would fail to start the executable
>> altogether because it wouldn't be able to resolve the reference to
>> GetModuleFileNameW(). It's not failing in that regard, so there
>> *must* be something there... I just can't tell what it should do by
>> default.
>
> You might want to read this: -
>
> http://msdn.microsoft.com/library/default.asp?url=/library/en-us/win9x/chilimit_5alv.asp
>
> Especially the part that says (emphasis mine):
>
> "However, Windows 95/98/Me does not implement the Unicode (or wide
> character) version of most functions. With few exceptions, these
> functions are implemented as *stubs* that simply return an error
> value."
>
> I suspect that GetModuleFileNameW on Win98 simply returns
> ERROR_NOT_SUPPORTED... and leaves ucs2_path uninitialized.
>
> BTW, you might want to check the return value of GetModuleFileNameW.
This is what I suspected was happening when I composed my e-mail last
night, I just couldn't find hard proof of it. Now that we know what
the problem, would you mind putting it into the issue tracker? I'm
going to see if I can learn to build Subversion on the Windows
platform, and then see if I can get this problem fixed.
>> Unfortunately, I cannot confirm it. I don't have access to a Win 98
>> machine. Every machine I can touch is an NT derivative. :-( With
>> that said, it would be hard to solve a problem when I can recreate it.
>> Before you file a bug report, I think we need to set up a reproduction
>> recipe. Can you provide a transcript of what you're doing? Can you
>> also include the path of where you installed Subversion, and the path
>> for where you're running svnadmin from?
>
> Installation path: C:\svn-win32-1.1.0
> Path where I'm running svnadmin from: C:\svn-win32-1.1.0\bin
> APR_ICONV_PATH: C:\svn-win32-1.1.0\iconv
>
> What I did:
> 1. Install Subversion 1.1.0.
> 2. Run 'svnadmin' (no arguments).
>
> Do you need more details?
No, this is fine. :-)
>> > I knew this the hard way. For a while, the 1.1.0-rc3 version of
>> > svnadmin worked. Now I think it's because the alignment of the planets
>> > were correct, and that the (uninitialized) ucs2_path wasn't corrupted
>> > with non-UTF-8 garbage.
>>
>> I think there is something else going on here... I'm not sure what
>> though. Every command-line utility is calling this routine, we should
>> be seeing the same failure in other tools.
>>
>> BTW, I compared the source tree for 1.1.0-rc3 and 1.1.0, and I don't
>> see a difference that would've all of sudden made svnadmin stop
>> working.
>
> What I meant is that when I was using Subversion 1.1.0-rc3, svnadmin
> worked for a while and then it stopped working. That why I suspect
> it's due to ucs2_path being uninitialized (i.e. memory corruption).
>
> If so, reproduction might be iffy.
I agree, the stars must have been aligned in order for it to squeeze
on by like this. :-) We'll see if there is something better that we
can do here.
>> If you can, try to get a reproduction recipe going. I'm going to see
>> if I can dig up an old Win 98 CD... I have VMWare, so I can install a
>> copy under a virtual machine temporarily. If I can reproduce the
>> problem, then we can enter it into the issue tracker, and get this
>> problem resolved.
>
> I think you should check what is the return value of
> GetModuleFileNameW on Win98.
>
> (As a side note, yes I know I should be using an NT-derivative. But
> with all the viruses out there, I'm waiting until AutoPatcher 2000
> [http://www.autopatcher.com/] comes out before I upgrade.)
I will, or I'll take a separate path for non-NT clients. One or the
the other will help fix this problem. Thanks for taking the time to
research this with me. Hopefully, I can get a patch created soon. If
I can't get the Windows build going on my machine, I'll try and rope
in one of the other Windows developers for Subversion and have them
try it.
Thanks!
-John
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Thu Oct 7 14:05:34 2004