[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CR->LF conversion with commit hooks?

From: <kfogel_at_collab.net>
Date: 2004-09-17 01:34:26 CEST

"Hamilton Link" <helink@sandia.gov> writes:
> I have this vague impression that the various svn repository hooks can
> do wonderous, magical things. Can they alter files being committed to
> the repository such that the client figures out this is happening and
> effectively auto-updates to capture changes made at commit time?

No, they can't. They can alter the files being committed, but there
is no way to tell the client about this -- therefore it is imperative
that you never, ever alter the files being committed on the server
side :-).

> At one point I think I saw someone asking if the commit hooks could
> auto-format C code; I don't know what the verdict on that was. In my
> case, it would be to enforce that code files are considered text
> files, convert CRs to LFs, do not have svn:executable as a property,
> and have svn:mime-type set to text/plain.

You shouldn't do this. But what you can do is have a hook that
rejects improperly formatted C code, so the commit fails, and the
committer fixes the problem. Or it can reject the commit for some
other reason, like the ones you give above.

Rejecting a commit via pre-commit-hook is always okay. Altering a
commit is not.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Fri Sep 17 03:18:06 2004

This is an archived mail posted to the Subversion Users mailing list.