[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Aborted commits and commit messages

From: Brian Mathis <bmathis_at_directedge.com>
Date: 2004-04-20 19:00:27 CEST

Ben Collins-Sussman wrote:

>On Mon, 2004-04-19 at 20:57, Richard Garand wrote:
>>When a commit fails for some reason, subversion prints an error like this:
>>svn: Your commit message was left in a temporary file:
>>svn: '/home/richard/projects/cms1/svn-commit.tmp'
>>Doesn't it make sense to load that message during the next commit attempt
>>instead of making the user to abort the commit, open the file, copy the
>>message, start a new commit, and paste the message? As of version 1.0.1, I
>>have never seen subversion do this.
>Why are you aborting the commit and copying/pasting?
>If, in your 2nd commit, your $EDITOR comes up blank, why not just insert
>the contents of the 'svn-commit.tmp' file into the current buffer? In
>emacs, it's a simple "C-X, i". I'm sure it's just as easy to do that in
>vi or any other editor.

I think the point is that it doesn't really make sense to have this
extra step. I've certainly aborted a commit a few times, only to
recommit, retype my log, then realize there was a .tmp file already
there. I can't say for certain that now that I know it's there, that I
would even remember the next time.

Dare I say it, but reading in the tmp file log message would be a great
UI improvement, just enough to add some nice polish.

Brian Mathis
Received on Tue Apr 20 19:02:01 2004

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.