[ Sorry for getting back so late, but I missed the reply. Tim, I think you
have a broken/misconfigured emailclient that omits the 'In Reply To' header
field, see RFC 2822.]
Leeuw van der, Tim wrote:
> Not that I have any code to contribute to solving the problem, but using a
> method-private static variable leaves you without any 'outside' control
> over the cached value. There's no way to invalidate the cached value, or
> to provide a non-default value *other* that by setting an environment
> variable (command-line parameter, stored preference).
True, that's a deficiency, but I'm not sure if that is a problem or not.
One could parse the commandline and then call setenv(), but that works just
until some other code calls svn_wc_adm_subdir() before that. Even better,
one should use a combo of parsing the commandline, querying the registry(if
on MS-windows), reading a configfile and the environment to get the value and
cache that.
However, that code lies in a library, which has no access to the commandline
and, as far as I'm concerned, better not access any other configuration
except when explicitly told to.
I'm not yet decided whether an environment var must be considered evil or not
in this context... :/
> For long-running programs,
> there's no way to pick up changes to the environment variable.
I don't think that's a problem, because this code is only for the working-copy
which is not used in server-precesses(right?). I'd even be tempted to say
that it would be a mistake to change the admin-dir on the fly once it was
used.
In that sense, I'd declare the admin-dir read-only after the first
read-access. Subsequent write-accesses should be logged as error.
cheers
Uli
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed Mar 10 18:35:07 2004