Re: Merging 2 repositories

On Wed, Feb 18, 2004 at 03:17:26PM -0500, John Peacock wrote:
>
> there would be no conflict. Clearly, the date-revision mapper should not
> make the assumtion that the revision number is anything except an artifact
> or the storage schema (i.e. has no direct relationship to commit date). At
> the very least, when performing date queries, the node date should be
> compared as the revision tree is walked at all points, and not just when
> locating the initial node.
>

Well, whether or not it should make this assumption is arguable, but the
fact is that it does make this assumption.

From subversion/libsvn_repos/rev_hunt.c:

/* Note: this binary search assumes that the datestamp properties on
   each revision are in chronological order. That is if revision A >
   revision B, then A's datestamp is younger then B's datestamp.

   If some moron comes along and sets a bogus datestamp, this routine
   might not work right.

   ### todo: you know, we *could* have svn_fs_change_rev_prop() do
   some semantic checking when it's asked to change special reserved
   svn: properties. It could prevent such a problem. */

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Wed Feb 18 22:07:06 2004