Mike Mason wrote:
> Garrett Rooney wrote:
>
>>> I've seen exactly this on the Windows svn client -- Control-C doesn't
>>> return immediately (locks are being released or something) and if you
>>> hit it again the process stops immediately and requires "svn cleanup".
>>
>>
>>
>>
>> Interesting. Does this patch fix the problem?
>>
>> Index: subversion/clients/cmdline/main.c
>> ===================================================================
>> --- subversion/clients/cmdline/main.c (revision 8181)
>> +++ subversion/clients/cmdline/main.c (working copy)
>> @@ -612,9 +612,13 @@
>>
>> /* A signal handler to support cancellation. */
>> static void
>> -sig_int (int unused)
>> +sig_int (int sig)
>> {
>> cancelled = TRUE;
>> +
>> + /* reset the signal handler because some operating systems reset it
>> when
>> + * it fires. */
>> + apr_signal (sig, sig_int);
>> }
>>
>> /* Our cancellation callback. */
>
>
>
> If I'm right about Ctrl-C Ctrl-C causing a nasty kill to the Subversion
> client, needing "svn cleanup" afterwards, is that something we'd want to
> fix for 1.0? If so, hit me with a binary and I'll check it.
What OS are you on? I only have access to Mac OS X and FreeBSD, so if
you're somewhere else I can't help you with getting a binary. I do
think this might be something we'd want to fix before 1.0 though.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Fri Jan 9 16:11:05 2004