[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: code reviewing and test enforcement?

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-11-29 15:05:08 CET

On Sat, 2003-11-29 at 06:37, David Garamond wrote:
> We're trying to use subversion instead of aegis for recent projects. For
> no particular reason, really, just to try out new stuffs. Also,
> subversion has tools like TortoiseSVN which makes it convenient to use.
>
> Using subversion, for projects involving several developers and a code
> reviewer, how might one implement obligatory testing (i.e., a test
> script has to be run first and succeeds before commit can continue) and
> code reviewing (i.e., when a developer commit a change, it goes to the
> code reviewer first; if the reviewer rejects the code, nothing is
> committed). Developers use "svn diff" + email the reviewer instead of
> "svn commit"? Use two repositories?

If you want the SCM system to enforce code review and unit tests, you'll
have to write a whole new "workflow" system on top of Subversion... it's
not part of Subversion itself.

Subversion certainly has the foundation laid out for you... in theory, a
commit transaction can live indefinitely, and a reviewer can examine it
before committing it. A simpler solution is to have people commit every
change to a real branch directory, and then have an "integrator" merge
each branch to the trunk, and then delete the branch.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Sat Nov 29 15:05:53 2003

This is an archived mail posted to the Subversion Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.