Re: force commit comments

I have a few questions...

On 2003-11-20 14:43:25 -0600, Ben Collins-Sussman wrote:
> SVNLOOK=/usr/local/bin/svnlook

Why using a full path, that may not be correct on all systems?
Isn't SVNLOOK=svnlook a better idea?

> LOG=`$SVNLOOK log -t "$TXN" "$REPOS"`
> echo "$LOG" | grep "[a-zA-Z0-9]" > /dev/null || exit 1

Why not

$SVNLOOK log -t "$TXN" "$REPOS" | grep "[a-zA-Z0-9]" > /dev/null || exit 1

?

Is the > /dev/null really necessary (the /dev/null redirection should
be done by subversion IMHO)? And what about stderr (fd 2)?

-- 
Vincent Lefèvre <vincent_at_vinc17.org> - Web: <http://www.vinc17.org/> - 100%
validated (X)HTML - Acorn Risc PC, Yellow Pig 17, Championnat International
des Jeux Mathématiques et Logiques, TETRHEX, etc.
Work: CR INRIA - computer arithmetic / SPACES project at LORIA
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org