Re: contribute minor improvement to diff-xls.js

On 30.06.2016 12:14, adriaan peens-hough wrote:
> gentlepeople
>
> i have made a minor improvement to the diff-xls.js utility that is
> bundled with tortoisesvn. just a few lines to use fc.exe to
> short-circuit the diff in case the files are identical.
>
> i've attached the patch as differenced with the latest code (rev
> 27268 from
> <https://sourceforge.net/p/tortoisesvn/code/HEAD/tree/trunk/contrib/diff-scripts/diff-xls.js>).

Thanks for the patch.
But I'm not sure about a few things:
first, the patch does not apply properly. It seems it wasn't created
with an svn tool? And it doesn't contain any context lines so it's not
possible to just apply it manually.

second: why would you want to short-circuit the diff? If the files are
identical, they wouldn't show up in any TSVN dialog like
commit/check-for-modifications or others. Or if they show up, they would
be marked with status "normal".

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3177655
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].