[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

TortoiseProc crash

From: André Ziegler <MagicAndre1981_at_live.com>
Date: Wed, 30 Dec 2015 01:26:56 -0800 (PST)

In the SVN log, I selected to include the merged rev data and here I got a crash at TortoiseProc!CLogEntryData::CLogEntryData+d2 [c:\tsvn_branch\tortoisesvn\src\tortoiseproc\logdialog\logdlgdatamodel.cpp @ 327]

After using .srcfix, windbg shows this line where the crash happens:

    , childStackDepth (parent == NULL ? 0 : parent->childStackDepth+1)

In the variable window I see a "Memory access error" for childStackDepth:

0:006> dx -r1 (*((TortoiseProc!CLogEntryData *)0xffffffffffffffff))
(*((TortoiseProc!CLogEntryData *)0xffffffffffffffff)) [Type: CLogEntryData]
    [+0x000] changedPaths [Type: CLogChangedPathArray]
    [+0x020] sDate [Type: std::basic_string<char,std::char_traits<char>,std::allocator<char> >]
    [+0x040] sBugIDs [Type: std::basic_string<char,std::char_traits<char>,std::allocator<char> >]
    [+0x060] sAuthor [Type: std::basic_string<char,std::char_traits<char>,std::allocator<char> >]
    [+0x080] sMessage [Type: std::basic_string<char,std::char_traits<char>,std::allocator<char> >]
    [+0x0a0] revision : Unable to read memory at Address 0x9f
    [+0x0a8] tmDate : Unable to read memory at Address 0xa7
    [+0x0b0] parent : Unable to read memory at Address 0xaf
    [+0x0b8] projectProperties : Unable to read memory at Address 0xb7
    [+0x0c0 (23: 0)] childStackDepth : Unable to read memory at Address 0xbf
    [+0x0c0 (24:24)] checked : Unable to read memory at Address 0xbf
    [+0x0c0 (25:25)] hasParent : Unable to read memory at Address 0xbf
    [+0x0c0 (26:26)] hasChildren : Unable to read memory at Address 0xbf
    [+0x0c0 (27:27)] nonInheritable : Unable to read memory at Address 0xbf
    [+0x0c0 (28:28)] subtractiveMerge : Unable to read memory at Address 0xbf
    [+0x0c0 (29:29)] unread : Unable to read memory at Address 0xbf
    [+0x0c0 (30:30)] bugIDsPending : Unable to read memory at Address 0xbf

So check parent->childStackDepth for being not NULL before accessing it.

WATSON_BKT_PROCVER: 1.9.3.27095
PROCESS_VER_PRODUCT: TortoiseSVN
WATSON_BKT_MODULE: TortoiseProc.exe

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3152636

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2015-12-30 10:27:04 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.