Re: problem using vendor branch feature (folder case mismatch)

On 02.12.2015 13:34, Stefan Hett wrote:

> I'm wondering the following line here:
> vv = versionedFiles.begin();
>
> While I don't want to waste your time, I can't spend the necessary time
> atm to do a thorough code/design review on that part. So pardon me if
> I'm completely off and the reasoning for that code lies in the intended
> design.
>
> The problem this line might cause is that if the first entry is removed,
> the second entry in the list would never be touched (because of the v++
> increment in the for-loop).
> In addition to that, this code section seems to have a runtime of O(n^2).
> If I'm not mistaken, the following change would resolve both "problems":
>
>
>
> Again, this is all under the presumption that the restart of the loop is
> not essential for this particular code.

You're right. Your implementation is much better!
Committed in r27010.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3149168
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].