RE: Re: Re: Detecting

> If the line ending style happened to match the native line endings, they show as not
> modified, correct? It's only when the actual line endings in the file are
> not the native style that the file is marked modified, correct?

Incorrect. As I mentioned in the initial post and my first reply to Stefan, the 'modified' status (the one which I consider improper) appears only with CRLF files and CRLF is the native line ending for Windows.

> I think if a line ending actually in use does not match the line ending SVN
> expects for that file, that marking it modified makes sense.

I disagree that it makes sense. When a user sets svn:eol-style to 'native', pending modifications of line endings in the working copy are not interesting for review in any way (because the user explicitly told Subversion not to track line ending changes). This indeed is pure property change. If nobody can come up with a use case when one does practically need to see the 'modified' status instead of 'modified (property change only)' in the situation when nothing but svn:eol-style has been changed, I should consider the current behavior as buggy (because cons have been mentioned by me in the initial post but I haven't heard any pros).

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3104614

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2015-03-11 22:29:58 CET