[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

TSVN 1.8.8 - Invalid revision passed to Log() cause found

From: Paul Gardens <gardensofdorwinion_at_gmail.com>
Date: Sun, 30 Nov 2014 06:52:26 -0800 (PST)

When a merge is attempted on a URL with user_at_host in it, bringing up the Log dialog to select a revision shows the message "Invalid revision passed to Log()" instead of the history.

The cause is that CMergeWizardRevRange::OnBnClickedShowlog() detects everything after the @ as the revision number. This fails the rev.IsValid() check, however the else condition (for 1.8.8) contained "rev == SVNRev::REV_HEAD" and did not to correctly assign "rev".

Commit 25955 corrects this and hopefully resolves the "Invalid revision passed to Log" issue for such URLs.

Possible workarounds until a release containing the fix:

Append a @ onto the merge url, an empty revision gets turned into HEAD rather than invalid.

If using plink for svn+ssh, save a session with the auto-login username set, and use the session name in your URL, removing the 'user@' portion from the SVN URL.




To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-11-30 15:52:32 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.