[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: empty action column in show log dialog

From: Ben Fritz <fritzophrenic_at_gmail.com>
Date: Fri, 28 Nov 2014 12:41:09 -0600

On Fri, Nov 28, 2014 at 9:26 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:

> On 28.11.2014 11:22, Simon Large wrote:
> > On 27 November 2014 at 19:40, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> >>
> >> On 26.11.2014 17:08, Ben Fritz wrote:
> >>> When I select a single revision, any files added in that revision have
> >>> "added" in the Action column. Modified files say "modified", deleted
> >>> files say "Deleted". In addition the file name changes color to reflect
> >>> the status.
> >>>
> >>> When I select multiple revisions, the file name still changes color, so
> >>> it appears that TortoiseSVN still knows what happened to that file.
> But,
> >>> the Action column is empty.
> >>
> >> Yes, that's because if you select multiple revisions, you get multiple
> >> actions per file. It would be very slow to generate a list of every
> >> action for every file. Also, the action column could get very, very
> wide.
> >
> > How so? There is still the same number of possible actions. I don't
> > think Ben is expecting a separate icon for every revision where the
> > file was modified, just a summary of what actions have been taken.
>
> Imagine someone selects 1000 revisions, and there are 1000 files
> affected in those 1000 revisions:
>
> for (file : affectedfiles)
> {
> DWORD actions = 0;
> for (rev : selectedrevisions)
> {
> actions |= action_of_file_in_rev;
> }
> }
> CreateActionListStringforFile(actions);
>
> As you can see, this operation would be very expensive.
> And now imagine a user hitting Ctrl+A to select all revisions...
>
>
>
>
But it already does SOMETHING like that, because the color of the files
that were only added, matches the "added" color on a single-revision
selection. The "modified" color matches. I think the "deleted" color
matches as well (I'm red-green color blind, I'm not sure whether the
deleted color is red or black or something else). So if enough parsing is
done to determine modified vs. added vs. deleted, why not put something in
the action column as well?

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091976

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-11-28 19:41:36 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.