[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Escape key closes commit dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 28 Nov 2014 16:52:57 +0100

On 28.11.2014 16:47, Jason Chown wrote:
> Hi,
>
> It might be just me, but I often lose my partial commit: I'll carefully
> select the files I want (reviewing the changes in each) and finally
> start typing the commit message. Oh - I have a typo, let's just change
> that. My muscle memory instantly hits escape to revert the selection
> (which works on Windows in most forms, browser address bars etc.), but
> no, the commit dialog is closed without verification! I don't think
> Escape has closed dialogs in most software since the late 80s...
>
> Can it at least offer an "abandon commit? OK/Cancel?" I hit the
> table-flipping state at least twice a week as it stands...

First: pressing escape always closes dialogs. Even today. It doesn't
close main windows but it always closes dialogs. And the commit dialog
is as the name says a dialog.

Second: While you want the escape key to NOT close the dialog, others
want the escape key to close any TSVN dialog immediately without any
confirmation or anything else even if it would mean getting corrupted
working copies:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091897

So the behavior as it is now will stay for now. Sorry - can't do it
right for everyone.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest interface to (Sub)version control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3091961
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-11-28 16:52:54 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.