[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in rename when "similar file name" renames are involved and file names include multiple dots

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 16 May 2014 18:46:21 +0200

On 16.05.2014 13:25, Tim Van Holder wrote:
> Tested with: TortoiseSVN 1.8.7, Build 25475 - 64 Bit , 2014/05/05 20:52:12
>
> Given a repository containing:
>
> Foo.Bar.csproj [in svn]
> Foo.Bar.csproj.user [not in svn + ignored]
>
> SVN Rename on the csproj file to Foo.Bar2.csproj:
> - asks whether or not similar file Foo.Bar.csproj.user should
> be renamed to Foo.Bar.csproj.user
> => clearly not right (no name change_
> - when Yes is selected:
> - 2 error dialogs are shown: "cannot move path X into itself"
> (one for each file)
>
> SVN Rename on the csproj file to Foo2.Bar.csproj:
> - asks whether or not similar file Foo.Bar.csproj.user should
> be renamed to Foo2.Bar.csproj.user
> - when Yes is selected:
> - the .csproj file is renamed correctly
> - an error is shown for the .user file:
> "Path C:\...\Foo.Bar.csproj.user does not exist" (but it does)
>
> SVN Rename on the csproj file to Foo2.csproj:
> - asks whether or not similar file Foo.Bar.csproj.user should
> be renamed to Foo2.Bar.csproj.user
> => bad: the Bar. part is not removed
> - when Yes is selected:
> - the .csproj file is renamed to Foo2.Bar.csproj (incorrect)
> - an error is shown for the .user file:
> "Path C:\...\Foo.Bar.csproj.user does not exist" (but it does)
>
> If the repository contains:
>
> Foo.Bar.csproj [in svn]
> Foo2.csproj.user [not in svn + ignored]
>
> SVN Rename on the csproj file to Foo2.csproj offers to rename
> "similar file" Foo2.csproj.user to itself. But it's not really
> similar, and even if it was, it shouldn't offer to rename it to
> itself.
>
> Some of these issues seem to match problems reported in issue
> #571 (which is marked as fixed in 1.8.3).
> One element seems to be that either only the name up to the
> first '.' is taken into account, or that the matching does not
> take the longest-possible match for every similar file.
> Another is that a misprocessing of the similar file's name also
> affects the base file (but that could be an effect of the fix
> for #571).
>
> Side remark: in the "path does not exist" dialog, the path name is
> hard-wrapped at some invisible edge, with the "does not exist" on
> the next line. Not sure if that's Windows doing it or tsvn, but it
> would be nicer if a path was broken on directory separators where
> possible.

Created issue #644 for this:
https://code.google.com/p/tortoisesvn/issues/detail?id=644

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3078531
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-05-16 18:50:04 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.