[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Revert or update to Issue 285: externals: prevent commit of pegged externals?

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 13 Aug 2013 20:20:43 +0200

On 13.08.2013 17:08, Dan Ellis wrote:
> Hello everyone,
> > Hi all,
> >
> > Issue 285 was added to prevent a commit when an external had a
> > pegged revision (only allowed for HEAD).
> >
> > I believe we should allow commits when the peg revision is the same
> > as the HEAD revision. I'm ok with preventing commits to pegged
> > revisions that are not the same as the HEAD. This makes some sense,
> > although seems a little bit over-protective.

if you peg to HEAD, then why even add a peg revision?
If you peg to a specific revision, then it won't be HEAD anymore when
you do the commit.
The only way to determine whether it's the same as HEAD would be to do a
diff with the repository.

Now imagine TSVN would have to do such a diff in the commit dialog.

100 file externals
1s time required to do a diff with the repository per file

--> 100s time required just to figure out whether the externals are the
same as HEAD.

--> users would be waiting outside my apartment for me to get out so
they can kill me.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-08-13 20:21:06 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.