I've updated to R23871 - my about dialog shows TortoiseSVN 1.7.11, Build 23871 - 64 Bit.
With the ValidateRect() removed (I reverted the file back to what's check in), TortoiseSVN hangs again. If I had a little more time tonight, I would have rebuild the debug version with the BeginPaint/EndPaint calls and looked at the PaintStruct to figure out what region needs repainting. I may have a few minutes to try that tomorrow.
I fully support fixing the problem properly...too many bugs are fixed with a work-around without understanding the cause.
Let me know if there's anything else you'd like me to try.
> On 29.01.2013 03:08, Terry Fisher wrote:
> > I updated the OnPaint() function to always call ValidateRect( NULL )
> > before returning, and that also appears to resolve the problem.
> > The original 1.7.11 version hangs every time. Switching to the
> > version with ValidateRect( NULL ), works every time, switching back
> > to the original version hangs.
> > One thing that is interesting is that the dialog doesn't appear to be
> > completely initialized when it hangs. I've attached a .jpg to show
> > what the window looks like...notice the lower portions of the window
> > don't have their normal blue background, and buttons appear
> > disabled.
> That indicates that it's not a problem with the list control? Since the
> list control is actually painted correctly.
> Sorry to bother you again, but can you try r23871 without the
> ValidateRect(NULL) statements and check if that solves the issue?
> If not, then I'll add the ValidateRect(NULL) statements.
> I do want to fix this issue, but if possible the right way instead of
> what I consider a workaround using ValidateRect.
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest interface to (Sub)version control
> /_/ \_\ http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-01-30 06:44:31 CET