Re: Heap corruption issue seen on Japanese systems

Hi all,

It could also be a translation problem, but since it only happens in the
file open dialog, the issue is probably not related to a l10n problem in
TortoiseSVN, because no TortoiseSVN specific dialog is shown.

However it would still be interesting to know if the
the Japanese TortoiseSVN language pack is installed and if yes, if the
problem arises only when TortoiseSVN is switched to Japanese.

But I seriously doubt that the problem is related to TortoiseSVN or to the
translation. Japanese is the most popular language pack and if there would
be a problem in something as standard as the windows file open dialog, we
would surely have heard of it.

Karl, you failed to mention which version of Windows (only Japanese) you
were running and which version of TortoiseSVN (32/64 bit) was installed on
that system.

2012/12/4 Stefan Küng <tortoisesvn_at_gmail.com>

> On 04.12.2012 15:12, Karl Nedwed wrote:
> > Hello,
> > I am writing on behalf of our software development group at Bio-Rad
> > Laboratories. We discovered a crash in our software on a Japanese system
> > that appears to point at a problem inside SVN code. Details are as
> follows:
> > Our software (Bio-Rad KnowItAll 9.5) uses the standard File Open dialog
> > box to import files into the software. On one Japanese system, there is
> > a crash almost every time a user invokes the File Open dialog box. The
> > Windows event log (exception code 0xc0000374) indicates a heap
> > corruption, and the crash dump that you can find below also points to
> > the File Open dialog box (location 0x4ec49b60 inside NT.dll).
> > We did a thorough review of all relevant code in our software and could
> > not find any problem. Then we noticed that Tortoise SVN (latest version
> > 1.7.10) was installed on that particular system. Uninstalling it fixed
> > the problem.
>
> The stack trace does not show the involvement of TSVN.
> Also, if there were a heap corruption in the TSVN shell dll, that would
> have been detected a long time ago.
>
> I really believe that you checked your own software carefully, but my
> guess is that you forgot to do one check: stack overflow.
>
> You see, when you use the shell dialogs, the shell also loads all shell
> extension dlls - it's basically an explorer instance since the files
> save/open dialogs are small explorer windows.
> Loading so many shell extension dlls also means that each one of those
> uses up some stack space.
> My guess is that your application runs out of stack space, and that's
> what's causing the heap corruption that's detected later.
>
> If your app reserves a lot of stuff on the stack and/or you reduced the
> stack size with the compiler option or you specified a small(er) value
> when calling CreateThread, then you will eventually run into such
> problems, whether you've got TSVN installed or not. Because you can not
> control how many shell extension dlls or other dlls get loaded into your
> process space.
>
> http://msdn.microsoft.com/en-us/library/ms682453%28VS.85%29.aspx
> http://msdn.microsoft.com/en-us/library/tdkhxaks%28v=vs.110%29.aspx
>
>
> > Among other modules, the Windows shell code also loads some SVN DLLs if
> > it is installed every time the File Open dialog box is invoked. This is
> > why we believe that the SVN code that is executed as part of the
> > standard Windows File Open dialog box is responsible for the heap
> > corruption. Unfortunately we were not able to identify a particular
> > reason why the problem only showed up on this Japanese system. We have
> > been using SVN for a long period of time, and we have never seen any
> > crash problems. We assume that a specific file on the Japanese system
> > causes a heap corruption (buffer overrun?) within the SVN code.
> > Although we are unfortunately not able to tell you specific steps how to
> > reproduce the problem, we thought that it would be worth reporting the
> > issue to you. There is a possibility that Japanese characters in a file
> > name or some other processing of Japanese characters cause a problem.
> > Please feel free to contact me any time in case you need more
> > information. Thank you.
>
> TSVN is fully functional with any characters, even Japanese ones. There
> also aren't any problems with Chinese or other non-English chars at all,
> at least not that I'm aware of.
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest interface to (Sub)version control
> /_/ \_\ http://tortoisesvn.net
>
> ------------------------------------------------------
>
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3033231
>
> To unsubscribe from this discussion, e-mail: [
> users-unsubscribe_at_tortoisesvn.tigris.org].
>

-- 
Cheers
- Lübbe
--
Please help me get more space on Dropbox :)
https://www.dropbox.com/referrals/NTIwMzcxNjI5
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net  PGP Key ID 0x23F511AB
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3033643
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].