Re: Nightly Build Client Side Hook Props

On 14.11.2012 19:00, Greg Creager wrote:
> Love the new hook props, allows us to set standard client side hooks
> for our group (we don't have access to server side in our env).
>
> Couple issues/thoughts: 1) The dialog that pops up asking to run,
> 'don't ask again' does not behave as I would expect. I would expect
> it to not ask again but remember the behavior. I want it to run the
> hook but not prompt me again. So I select the checkbox to not ask
> again and then hit run, but after that I never get the hook
> execution.

Fixed in r23477.

> 2) Current implementation breaks the hook when you branch, forcing
> you to go update the property each time. Options: a) For the hook
> script, use relative paths to the hook property. I could have the
> script in the repo and simply specify ./hook.js. That path would be
> relative to the hook property, not the commit. b) Or allow for

Can't work. Imagine a hook command line like this:
./cmd.exe ./path/to/script ./optional_argument

which one is the relative path to the script?

> pattern match search:
> %REPOROOT%/comps/cmf/[branches/int|trunk]/hook.js

the problem here is that the name of the branch can be anything. And
using wildcards again poses a security risk here.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3028401
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].