Re: SubWCRev: Options to recognize "tags" folder, "all externals set explicit" & more

On 27.09.2012 07:45, Jan Linnenkohl wrote:
> Hello Stefan,
>
> so I am nearly done with the functionality For SubWCRev. The only
> things is the COM interface, where I have to bring the "-E" parameter
> to the "GetWCInfo" function. One possiblity would be to add another
> "bool" variable, or change it to "short" (0: Off, 1: "-e", 2: "-E")
> or use an enum. What should I use, I think "short" would stay
> compatible with old versions?

I think it's time to introduce ISubWCRev2 here and add there a new
GetWCInfo function.
We broke the COM rule about never changing existing interfaces before,
but only because it's implemented as an out-of-process COM object and I
figured that the COM object would only be used by scripts anyway.
But changing an existing function and not just adding new functions
would break even scripts using the COM object, so we have to introduce a
new interface.

>
> Also I added the "HasMixedRevisions" to the COM interface. That is
> for the case, when you have an fixed external, which was manually set
> to HEAD revision. This should lead to an mixed revision error, also
> when MinRev & MaxRev are equal the head revision.
>
> Could you please check, if I have to do some other things for this?

Currently reviewing your patch. Looks very good.
I'll commit your patch soon, just have to make some minor adjustments.

And I think I'll just add the new interface as well.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3010740
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].