Re: Version 1.7.4 crashes XP Explorer

On Jan 31, 10:22 am, Simon Large <simon.tortoise..._at_gmail.com> wrote:
> > When using svn from command line, I found the problem is error in svn config file.
> Would you like to tell us what the error in the config file was?

I had the same problem (error in config file) a few days back. In my
case I had
accidentally deleted the leading hash marks on some comment line in
the
"servers" fiel. But it really doesn't matter.
The culprit is the following code snippet from TSVN (in file src/SVN/
SVNConfig.cpp):

SVNConfig::SVNConfig(void)
{
    svn_error_t * err;
    parentpool = svn_pool_create(NULL);

    err = svn_config_ensure(NULL, parentpool);
    pool = svn_pool_create (parentpool);
    // set up the configuration
    if (err == 0)
        err = svn_config_get_config (&(config), g_pConfigDir,
parentpool); <----

    patterns = NULL;

    if (err != 0)
    {
        svn_error_clear(err);
        svn_pool_destroy (pool);
        svn_pool_destroy (parentpool);
 
exit(-1);
<----
    }
}

i.e. ANY error returned from svn_config_get_config() will exit()
the program (in this case Windows Explorer) without any notice
what's going on.

Note that there several unexplained "Explorer crashes when using
right
button menu" posts which might also be the result of this.
To check, just run any CLI command (even "svn help") - it will
print a diagnostic when there's an error in a config file.

Cheers, Roderich

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2936122

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-03-15 13:04:09 CET