Re: Checked file count problem

On 14.10.2011 11:09, Konstantin Kolinko wrote:
> 2011/10/14 Stefan Küng<tortoisesvn_at_gmail.com>:
>> On 12.10.2011 21:58, Jean-Francois Cote wrote:
>>> Hello,
>>>
>>> I think I have found a small bug in the new 1.7.0 version.
>>>
>>> Here is my version: TortoiseSVN 1.7.0, Build 22068 - 32 Bit ,
>>> 2011/10/10 09:48:29
>>>
>>> I use it on a Windows Vista 32 bit version.
>>>
>>> The bug is very easy to reproduce. Just do a commit over a folder
>>> that have for example 10 modified files and 5 normal file (status).
>>> Click on the new "Modified" option to select the modified files.
>>>
>>> When clicked, the total number of selected file in the bottom-right
>>> corner will update to 10 (instead of 15) but the 15 files will stay
>>> selected.
>>>
>>> So if you unselected manually 11 files, you will comes to a total
>>> count of selected file of -1. And since it's smaller than 0, the OK
>>> button is disabled.
>>>
>>> So it's a very small bug but I think it must also be very easy to
>>> fix.
>>>
>>> Feel free to ask question if something is not clear!
>>
>> I can not reproduce this. The count is always correct.
>> The 5 normal files, are they shown in the commit dialog? If so, why?
>> Normal files should not even be shown.
>>
>
> I cannot reproduce showing unmodified files, but I can reproduce
> negative counter.
>
> 1. Start with a directory that has 1 modified and 1 unversioned file
> 2. Open Commit dialog. Click "All". 2 files are selected.
> 3. Click "Modified". 2 files are selected, but in the lower right
> corner it is written that "1 files selected".
> 4. Uncheck both of the files by clicking the checkboxes in the first column.
> The message becomes "-1 files selected"
>
> The same bug also affects "Versioned" and "Non-versioned" selectors:
> behaviour is the same as with Modified:
> Click "All", click one of them, they report that "1 files selected"
> but actually both of them are selected.
>
> I have not tested how "Added" or "Deleted" selectors behave - they
> were disabled in this test.

Thanks. I can reproduce it now.
I've opened issue #92 for this:
http://code.google.com/p/tortoisesvn/issues/detail?id=92

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2855160
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].