[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.7 TortoiseMerge word wrap can cause crash

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 19 Aug 2011 19:11:31 +0200

On 19.08.2011 17:54, Stein Somers wrote:
> The word wrap feature in TortoiseMerge is welcome, but sometimes it bites. I
> haven't been able to reproduce it exactly. My gut feeling as a C/C++ developer
> is that some memory is not initialized. I'm on build 21850 now.
>
> The steps to reproduce:
> 1. Open some SVN diff, through various ways.
> 2. Toggle the word wrap button (Ctrl-P).
>
> There are two cases now:
> 2.1. About 2 times out of 3, all is fine. TortoiseMerge shows the top of the
> files, and further toggling will work too. Close the window and open it again,
> and all is fine. Do something else or open a second window, and you risk
> switching over to case 2.2
>
> 2.2 Sometimes, TortoiseMerge scrolls beyond the bottom of the files, showing a
> blank screen. You can scroll back up fine. Toggling the word wrap button again
> scrolls down again, every time.
>
> 3. Only if you got into case 2.2, and there are whitespace differences between
> the files, and you switch the radio buttons to ignore or compare whitespace,
> there's an access violation in TortoiseMerge.exe. With debugging symbols
> extracted, according to the Visual Studio 2005 debugger, the "this" pointer is
> null in CMainFrame::OnViewComparewhitespaces. Top of the stack trace:
>
> TortoiseMerge.exe!CMainFrame::LoadViews(int line=416) Line 600 + 0x2e bytes
> TortoiseMerge.exe!CMainFrame::OnViewComparewhitespaces() Line 2338 + 0xb bytes
> mfc100u.dll!000000006deb3e1d()

I'm unable to reproduce this.
does it happen with all files you diff? Or just some?

The stacktrace is also wrong: toggling word wrap would happen in
OnViewWraplonglines(), not OnViewComparewhitespaces().

If you're using the latest nightly build, you can send me the crash dump
file: as long as the next nightly build isn't running yet, the debug
symbols would still be there for me to analyze the dump.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2825289
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-08-19 19:12:16 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.