Re: TortoiseSVN 1.7 beta1 crashes on exit (was Re: First Beta of TortoiseSVN 1.7)

On 10.08.2011 07:36, Dave Huang wrote:
> On 7/26/2011 1:36 PM, Dave Huang wrote:
>> On 7/26/2011 12:59 PM, Stefan Küng wrote:
>>> Wow, very good and detailed analysis! Thanks a lot!
>>>
>>> Fixed the hooking in r21724. Can you try the next nightly build
>>> please?
>>
>> Great, thanks! :) Sure, I'll give it a try...
>
> Uh oh, it had been working with no problems, but earlier today, I got a
> crash on exit that looks like the exact same problem. It's not
> reproducible though :(
>
> BtMmHook.dll tries to call SetUnhandledExceptionFilter(), but its IAT
> entry points to what WinDbg calls<Unloaded_CrashRpt.dll>+0xe654--i.e.,
> what would've been CrashRpt.dll+0xe654, except CrashRpt.dll has already
> been unloaded.
>
> I haven't had a chance to look into it further, but I wonder if there's
> some situation (race condition?) where CAPIHook::Uninstall() doesn't get
> called before CrashRpt is unloaded?
>
> This was with TSVN 1.7 beta 2 on Windows 7 SP1 x64.

I added an explicit shutdown of the crash reporter in r21809.
This should avoid that race condition.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2814091
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].