Re: BUG: wrong number of bytes transferred shown in update dialog

On 09.02.2011 15:34, Dietmar Suoch wrote:
> hello tortoisesvn community,
>
> i just encountered a bug. i made a huge update on repository.
> after a while the number for "bytes transferred" got negative.
> it is possible a numerical overflow or just wrong calculation ...
>
> maybe i am completely wrong here, but i just had a short moment to try
> to narrow this down.
>
> coming from CSVNProgressDlg::OnSVNProgress()
>
>
> struct SVNProgress
> {
> apr_off_t progress; ///< operation progress
> apr_off_t total; ///< operation progress
> apr_off_t overall_total; ///< total bytes transferred, use
> SetAndClearProgressInfo() to reset this
>
> "apr_off_t used as a byte counter rolls over fairly quickly on i386."
> http://www.mail-archive.com/dev@httpd.apache.org/msg22011.html
>
> maybe some dev could check/confirm/fix this?
>
> keep up the good work and thanks for your effort!
> best regards,

In the apr version we use on trunk, apr_off_t is defined as an __int64
which should be big enough.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2703086
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].